fea: add blocking APIs for httpsig-hyper #10
+313
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #9
In my earlier comment on #9, I mentioned restructuring the core traits to be sync. After reviewing the implementation, the async internals use join_all for concurrent batch processing in
set_message_signatures/verify_message_signatures, so rewriting them as sync would lose that benefit. Instead, this PR takes a simpler approach.Add
MessageSignatureReqSyncandMessageSignatureResSynctraits as sync wrappers for the existing async traits. Each*_syncmethod delegates to the async counterpart viafutures::executor::block_on, so the async internals remain untouched.Gated behind a blocking feature (default-on), which only adds futures/executor as a dependency. Note that calling
*_syncmethods from within an async runtime will panic — this is documented on the trait definitions.